rework handling of doc attributes on macro calls - #161514
Conversation
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-attributes
| error[E0658]: this subset of the `doc` attribute is meant for internal use only | ||
| --> $DIR/feature-gate-rustdoc_internals.rs:11:3 | ||
| | | ||
| LL | #[doc(fake_variadic)] |
There was a problem hiding this comment.
Could you make this point to fake_variadic rather than doc?
rustbot
added
S-waiting-on-author
| } | ||
|
|
||
| // FIXME accidentally allowed on Stable Rust | ||
| if target == Target::MacroCall && is_doc_non_lit_expr(attr) { |
There was a problem hiding this comment.
This is an independent change from the feature gate changes, I'd prefer this to be in an independent commit if it's not too much of a hassle
There was a problem hiding this comment.
I'd prefer if my commits can stand on their own, so I'd rather not do this.
Moving the feature parsing also requires changes to how OmitDoc is used, in order to correctly feature gate
#[doc(fake_variadic)]
//~^ ERROR this subset of the `doc` attribute is meant for internal use only [E0658]
println!();I think it would be simpler to just do it all in one commit.
639ab86 to
6c8b490
Compare
This comment has been minimized.
This comment has been minimized.
6c8b490 to
34bac0b
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
4 participants
#160904 but with the fcw changes removed
r? @JonathanBrouwer